Skip to content

OCPCLOUD-2010: Re-vendor api and library-go for external platform support#3745

Merged
openshift-merge-robot merged 2 commits into
openshift:masterfrom
adriengentil:revendor-library-go
Jun 21, 2023
Merged

OCPCLOUD-2010: Re-vendor api and library-go for external platform support#3745
openshift-merge-robot merged 2 commits into
openshift:masterfrom
adriengentil:revendor-library-go

Conversation

@adriengentil

@adriengentil adriengentil commented Jun 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Revendor openshift/api and openshift/library-go in order to support the
external platform type when feature set TechPreviewNoUpgrade is
enabled.

library-go PR: openshift/library-go#1496
API PR: openshift/api#1434

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 13, 2023
@openshift-ci-robot

openshift-ci-robot commented Jun 13, 2023 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown
Contributor

@adriengentil: This pull request references OCPCLOUD-2010 which is a valid jira issue.

Details

In response to this:

Revendor openshift/api and openshift/library-go in order to support the
external platform type.

library-go PR: openshift/library-go#1496
API PR: openshift/api#1434

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2023
@openshift-ci

openshift-ci Bot commented Jun 13, 2023

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

elmiko
elmiko reviewed Jun 13, 2023
View reviewed changes

@elmiko elmiko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just waiting on the upstream PRs so we can revendor

@adriengentil
OCPCLOUD-2010: Re-vendor api and library-go for external platform sup…
b4dbbe5 
…port

Revendor openshift/api and openshift/library-go in order to support the
external platform type.

library-go PR: openshift/library-go#1496
API PR: openshift/api#1434
@adriengentil
adriengentil force-pushed the revendor-library-go branch from 94c484c to b4dbbe5 Compare June 15, 2023 08:23
@adriengentil
adriengentil marked this pull request as ready for review June 15, 2023 08:24
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 15, 2023
@openshift-ci
openshift-ci Bot requested review from cgwalters and yuqi-zhang June 15, 2023 08:24
@elmiko

elmiko commented Jun 15, 2023

Copy link
Copy Markdown
Contributor

looks like the template output needs to be adjusted for the change in feature gates perhaps?

@adriengentil

adriengentil commented Jun 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

TestFeatureGateDrift test fails with:

 kubelet_config_features_test.go:45: template FeatureGates do not match openshift/api FeatureGates: (tmpl=[map[AlibabaPlatform:true OpenShiftPodSecurityAdmission:true RetroactiveDefaultStorageClass:false]], api=[&map[AlibabaPlatform:true CloudDualStackNodeIPs:true OpenShiftPodSecurityAdmission:true RetroactiveDefaultStorageClass:false]]

looks like the template output needs to be adjusted for the change in feature gates perhaps?

where is this template? 👀

@adriengentil

adriengentil commented Jun 15, 2023

Copy link
Copy Markdown
Contributor Author

ok I think it's this one https://github.com/openshift/machine-config-operator/blob/master/templates/master/01-master-kubelet/_base/files/kubelet.yaml

@adriengentil
Update feature gate in kubelet templates
6442768 
Required to pass FeatureGateDrift unit test
@elmiko

elmiko commented Jun 15, 2023

Copy link
Copy Markdown
Contributor

the e2e failures look related to csi driver issues, i don't think it is being caused by this pr.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2023
@adriengentil

adriengentil commented Jun 19, 2023

Copy link
Copy Markdown
Contributor Author

/retest

@adriengentil

adriengentil commented Jun 20, 2023

Copy link
Copy Markdown
Contributor Author

/assign sinnykumari
As @elmiko said, the jobs look to be failing for unrelated reasons (reaching some kind of limits in AWS for the hypershift one)

@openshift-ci-robot

openshift-ci-robot commented Jun 20, 2023 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown
Contributor

@adriengentil: This pull request references OCPCLOUD-2010 which is a valid jira issue.

Details

In response to this:

Revendor openshift/api and openshift/library-go in order to support the
external platform type when feature set TechPreviewNoUpgrade is
enabled.

library-go PR: openshift/library-go#1496
API PR: openshift/api#1434

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adriengentil

adriengentil commented Jun 21, 2023

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@adriengentil

adriengentil commented Jun 21, 2023

Copy link
Copy Markdown
Contributor Author

/retest

@jkyros

jkyros commented Jun 21, 2023

Copy link
Copy Markdown
Member

Awesome, hypershift passed
/approve

@openshift-ci

openshift-ci Bot commented Jun 21, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, elmiko, jkyros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2023
@openshift-ci

openshift-ci Bot commented Jun 21, 2023

Copy link
Copy Markdown
Contributor

@adriengentil: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 6442768 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
openshift-merge-robot merged commit 668672c into openshift:master Jun 21, 2023
ptalgulk01 pushed a commit to ptalgulk01/machine-config-operator that referenced this pull request May 15, 2026
@openshift-merge-robot
Merge pull request openshift#3745 from adriengentil/revendor-library-go
6829243 
OCPCLOUD-2010: Re-vendor api and library-go for external platform support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters
@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang
1 more reviewer
@elmiko elmiko elmiko left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@elmiko elmiko

@sinnykumari sinnykumari

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@adriengentil @openshift-ci-robot @elmiko @jkyros @sinnykumari @openshift-merge-robot